Set content type to application/json for flask.make_response with JSON data#54
Closed
pixeebot[bot] wants to merge 1 commit intodevelopfrom
Closed
Conversation
Contributor
Author
|
I'm confident in this change, but I'm not a maintainer of this project. Do you see any reason not to merge it? If this change was not helpful, or you have suggestions for improvements, please let me know! |
Contributor
Author
|
Just a friendly ping to remind you about this change. If there are concerns about it, we'd love to hear about them! |
Contributor
Author
|
This change may not be a priority right now, so I'll close it. If there was something I could have done better, please let me know! You can also customize me to make sure I'm working with you in the way you want. |
udhayprakash
deleted the
pixeebot/drip-2024-12-21-pixee-python/flask-json-response-type
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default
mimetypeformake_responsein Flask is'text/html'. This is true even when the response contains JSON data.If the JSON contains (unsanitized) user-supplied input, a malicious user may supply HTML code which leaves the application vulnerable to cross-site scripting (XSS).
This fix explicitly sets the response type to
application/jsonwhen the response body is JSON data to avoid this vulnerability. Our changes look something like this:from flask import make_response, Flask import json app = Flask(__name__) @app.route("/test") def foo(request): json_response = json.dumps({ "user_input": request.GET.get("input") }) - return make_response(json_response) + return make_response(json_response, {'Content-Type':'application/json'})More reading
I have additional improvements ready for this repo! If you want to see them, leave the comment:
... and I will open a new PR right away!
🧚🤖 Powered by Pixeebot
Feedback | Community | Docs | Codemod ID: pixee:python/flask-json-response-type